fixed onLayout measurements on web #3019
Conversation
adids1221
added
the
Important for Next Release
adids1221
changed the title
| @@ -216,6 +217,7 @@ const TabBar = (props: Props) => { | |||
| activeBackgroundColor={activeBackgroundColor} | |||
| {...item} | |||
| {...context} | |||
| style={[{flex}, item?.style]} | |||
There was a problem hiding this comment.
Can you memoize this style, it might affect performance if you are passing inline array style
| @@ -201,8 +201,16 @@ const TabBar = (props: Props) => { | |||
| } | |||
| }); | |||
|
|
|||
| const tabBarItemStyle = useMemo(() => | |||
There was a problem hiding this comment.
Is it working?
You are memoizing a function that returns a value and not the value
There was a problem hiding this comment.
I had an issue, changed it to useCallback and passed the tabBarItemStyle as dependency to the tabBarItems.
Checked on mobile and web.
|
@ethanshar as we spoke, passing |
| @@ -8,11 +8,13 @@ import {Colors, Typography, Spacings} from '../../style'; | |||
| import Badge, {BadgeProps} from '../badge'; | |||
| import View from '../view'; | |||
| import TabBarContext from './TabBarContext'; | |||
| import Constants from '../../commons/Constants'; | |||
| import {TabControllerBarProps} from './TabBar'; | |||
There was a problem hiding this comment.
change to import type {TabControllerBarProps} from './TabBar';
It might have a cyclic require because TabBar imports TabBarItem and TabBarItem imports TabBar
Maybe just importing with type is ok
Description
TabBarControllerfix item size on web.TabBarItemflex issue, settingflex to 1on web only ifspreadItemsis set to true.Handeling the style of the
TabBarItemfromTabBar, thestylepassed via propsoverrideit.Changelog
TabBarControllerfix item size on web.Additional info
ticket 4115