Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typography-deprecation - JSX should use short version #810

Merged
merged 1 commit into from
Jun 11, 2020
Merged

typography-deprecation - JSX should use short version #810

merged 1 commit into from
Jun 11, 2020

Conversation

M-i-k-e-l
Copy link
Contributor

typography-deprecation - JSX should use short version (no Typography prefix) - fix

@M-i-k-e-l M-i-k-e-l requested a review from ethanshar June 10, 2020 17:47
ethanshar
ethanshar reviewed Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@ethanshar ethanshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@M-i-k-e-l
Do we have a test for it?

@M-i-k-e-l
Copy link
Contributor Author

@M-i-k-e-l
Do we have a test for it?

I did not find a way to test fix other than to add logs and run the tests, so no.

@ethanshar ethanshar merged commit ed2812f into master Jun 11, 2020
@M-i-k-e-l M-i-k-e-l deleted the fix/typography-deprecation-jsx-should-use-short-version branch September 21, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar ethanshar approved these changes

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@M-i-k-e-l @ethanshar