Migrate to RN62 #837
Merged
Migrate to RN62 #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ethanshar
commented
Jul 2, 2020
ethanshar
commented
- iOS migrate is completed
- Android also, only having issue with adding our native packages if can take a look please
ethanshar
commented
Jul 2, 2020
| List<ReactPackage> packages = new PackageList(this).getPackages(); | ||
| // Packages that cannot be autolinked yet can be added manually here, for example: | ||
| // packages.add(new MyReactNativePackage()); | ||
| // packages.addAll(new UiLibPackageList(this).getPackageList()); |
There was a problem hiding this comment.
@M-i-k-e-l
I left this in comment cause it fail the build.
Not sure exactly how to solve it, i'm sure you'll have an idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.