fix: mixin bug with experimentalSelectorInference #2909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
added
bug
barak007
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case regression that causes a build error. The case involves a combination of mixin as the selector of
@st-scopewith theexperimentalSelectorInference=truemode.The difference is that when
experimentalSelectorInferenceis on, the transformer doesn't flat@st-scopebefore running, and the alternative@st-scopetransformation flow doesn't pass the inferred selector mixin value to transform the mixin fragment.The fix is simply passing along the inferred value to the
@st-scopetransformation process, so it can work in the same way.This is a quick/dirty fix, but I would like to refactor the entire process to handle all the context and inference values in a cleaner way.