feat: strict custom property #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- omit from st-symbol until it is required there
idoros
added
feature
barak007
reviewed
Dec 3, 2023
barak007
reviewed
Dec 3, 2023
barak007
reviewed
Dec 3, 2023
barak007
reviewed
Dec 3, 2023
- wait till someone complains and improve the general ignore configuration
- instead of piping them everywhere
barak007
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr introduces a new feature: the
strictCustomPropertyflag, which ensures that custom property usage always relays on a defined property and does not define a property by itself.Previously, the behavior was more lenient, allowing custom property definition via get/set methods within a stylesheet. However, with the
strictCustomPropertyflag activated, any reference to an undeclared property (e.g.--undeclared: redorcolor: var(--undeclared)) will result in a diagnostic error being reported.It's important to note that this behavior applies only to
st.cssstylesheets and not native CSS stylesheets..Additionally, this pr introduces a new flags option in the Stylable configuration, allowing for the activation of the
strictCustomPropertyflag.