#4008 - Allow packages and payloads over 2GiB #228
Conversation
src/test/WixToolsetTest.CoreIntegration/WixToolsetTest.CoreIntegration.csproj
Outdated
Show resolved
Hide resolved
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/data/large_file.dat
Show resolved
Hide resolved
|
One last nit: could you rebase these changes down to a single commit? I prefer to see the change and its test(s) all together in the same commit for future reference. Also, the separate commits for review feedback add noise to the history. Thanks. PS: Sorry, should have mentioned that in last review. |
|
Ok no worries, I'll do that now. |
AlexKubiesa
force-pushed
the
n4008-large-payload
branch
from
2729a1c
to
ec6c989
Compare
| @@ -0,0 +1 @@ | |||
| This is a fakeba.dll | |||
There was a problem hiding this comment.
@robmen Like you wanted them to narrow what was being tested, I would like tests not to have their own files unless it's necessary. Creating fake BA dlls and using localization seems like overkill in most scenarios and will also bloat the repo.
There was a problem hiding this comment.
I don't disagree but we should clean up all the tests to work this way.
There was a problem hiding this comment.
I already write all of my tests that way, I haven't looked lately at how many need to be cleaned up.
This should resolve wixtoolset/issues/issues/4008.
The fix itself was simple - just converting an int to a long.
For the test, I basically copied the existing pattern in
BundleFixture. The data filelarge_file.datcommitted to the repo is a dummy file which gets enlarged to 2.5GiB during the test. It then gets deleted at the end of the test to avoid taking up a lot of space.