This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
#4008 - Allow packages and payloads over 2GiB #228
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/Bundle.en-us.wxl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
|
||
<!-- | ||
This file contains the declaration of all the localizable strings. | ||
--> | ||
<WixLocalization xmlns="http://wixtoolset.org/schemas/v4/wxl" Culture="en-US"> | ||
|
||
<String Id="BundleName">~TestBundle</String> | ||
|
||
</WixLocalization> |
13 changes: 13 additions & 0 deletions
13
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/Bundle.wxs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs"> | ||
<Bundle Name="!(loc.BundleName)" Version="!(bind.packageVersion.test.msi)" Manufacturer="Example Corporation" UpgradeCode="047730a5-30fe-4a62-a520-da9381b8226a"> | ||
<BootstrapperApplication> | ||
<BootstrapperApplicationDll SourceFile="fakeba.dll" /> | ||
</BootstrapperApplication> | ||
<Chain> | ||
<MsiPackage SourceFile="test.msi"> | ||
<MsiProperty Name="TEST" Value="1" /> | ||
<Payload Compressed="no" SourceFile="large_file.dat" /> | ||
</MsiPackage> | ||
</Chain> | ||
</Bundle> | ||
</Wix> |
1 change: 1 addition & 0 deletions
1
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/data/MsiPackage/Shared.dll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This is Shared.dll. |
1 change: 1 addition & 0 deletions
1
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/data/MsiPackage/test.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This is test.txt |
1 change: 1 addition & 0 deletions
1
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/data/fakeba.dll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
This is a fakeba.dll | ||
2 changes: 2 additions & 0 deletions
2
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/data/large_file.dat
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
When running the tests, this file will be overwritten with 2.5GB of data to test how Wix handles large files. We've avoided | ||
robmen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
committing such a large file to Git as it would bloat the repo. |
Binary file added
BIN
+32 KB
src/test/WixToolsetTest.CoreIntegration/TestData/LargePayload/data/test.msi
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robmen Like you wanted them to narrow what was being tested, I would like tests not to have their own files unless it's necessary. Creating fake BA dlls and using localization seems like overkill in most scenarios and will also bloat the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree but we should clean up all the tests to work this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already write all of my tests that way, I haven't looked lately at how many need to be cleaned up.