Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wixstdba command line parameters need a case insensitivity option #3777

Closed
wixbot opened this issue Sep 18, 2012 · 1 comment · Fixed by wixtoolset/wix#21
Closed

wixstdba command line parameters need a case insensitivity option #3777

wixbot opened this issue Sep 18, 2012 · 1 comment · Fixed by wixtoolset/wix#21
Assignees
Milestone

Comments

@wixbot
Copy link

wixbot commented Sep 18, 2012

The main thing preventing us from using the wixstdba outright at this point is the fact that anything coming in from the command line is case sensitive.

MSIs take commandline parameters and uppercases them when it puts them in properties, effectively making anything coming in case insensitive.

Although this may not be a good general solution, we have modified the wixstdba to make it work for us the following way:

In the ParseOverridableVariablesFromXml function we have made the overridable variable string list case insensitive:

 DictCreateStringList(&m_sdOverridableVariables, 32, DICT_FLAG_CASEINSENSITIVE);

Then in the ProcessCommandLine function we uppercase the sczVariableName before we set the variable:

StrStringToUpper(sczVariableName);
hr = m_pEngine->SetVariableString(sczVariableName, sczVariableValue);

Then although the variable definition doesn't need to be uppercase, anytime we refer to the bundle variable, we make sure it is uppercase

e.g.

<MsiProperty Name="passToMSIVariable" Value="[PASSTOMSIVARIABLE]"/>

Originally opened by darba from http://sourceforge.net/p/wix/bugs/3092/

@wixbot
Copy link
Author

wixbot commented Oct 22, 2013

Originally changed by barnson
Area set to extensions
Release changed from v3.8 to v3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants