Move Bundle/@CommandLineVariables into Bal.wixext

[rseanhall]

Feature requests

If this issue is a feature request:

• Describe the scenario and benefits that the feature supports.

In v4, support was added for hidden variables to be masked in the log even if the name of the variable on the command line was a different case than the one declared in the bundle (#3777). The default is that all public variables should be uppercase, and Bal.wixext will throw an error if a variable is marked as overridable and it's not all uppercase when the bundle specified that all public variables should be uppercase. The built-in wixstdba themes use "InstallFolder" as the variable name in the options dialog, but if the user tries to mark this with bal:Overridable="yes" then that will fail to build.

• Describe how you're accomplishing the feature today (if possible).

Custom theme or setting Bundle/@CommandLineVariables to caseSensitive.

• Describe what you'd like the new feature to do.

Change the themes to use INSTALLFOLDER instead of InstallFolder.

[rseanhall]

We discussed this and we're going to change how the Bundle/@CommandLineVariables work. The engine will always do a case insensitive match, and will hide the value if it finds any hidden variable with the name. It will be moved out of the core toolset and into Bal.wixext. The default setting will be changed to caseSensitive to match v3. The uppercase setting will change to caseInsensitive (this will require changes to how Bal.wixext validates the overridable variables aren't overlapping). This means the InstallFolder name doesn't need to change.