Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicode support for WcaLog #4207

Open
wixbot opened this issue Nov 24, 2013 · 3 comments
Open

Add unicode support for WcaLog #4207

wixbot opened this issue Nov 24, 2013 · 3 comments

Comments

@wixbot
Copy link

wixbot commented Nov 24, 2013

I would like to add unicode support to the WcaLog function and any function that depends on this function for WiX 4.x and 3.x. I have requested to implement this feature via the Dev Mailing List and Blair Murri has requested that I file a ticket and that triage will provide rules to follow on implementing this feature.

Suggestions for implementation

For WiX 4.x, I would like to replace the current function WcaLog with two new functions that have the same name but end in A/W. A define would be made under the old name and would point to one of two new functions based on the compilers setting for Unicode support. This strategy would also apply for any function that WcaLog depends on.

For WiX 3.x, I would like to add two new functions that have the same name as WcaLog but end in A/W. The existing function would remain supporting ANSI strings, so it does not break existing code that already depend on this function. This strategy is similar to the one above but without the define that maps to one of the two new functions. Any functions that depend on WcaLog would also follow this strategy.

In case its not know, functions that end in 'A' generally support Ansi Strings and functions that end in 'W' generally support Wide Strings

Originally opened by kneuse

@wixbot
Copy link
Author

wixbot commented Nov 26, 2013

Originally changed by barnson
Area changed from wixtoolset.org to sdk
AssignedTo set to kneuse
Release changed from v3.8 to v3.9

@wixbot
Copy link
Author

wixbot commented May 22, 2014

The deadline for v3.9 work is 6-June. Please add a comment here if you intend to complete this work for v3.9.

@wixbot
Copy link
Author

wixbot commented Jun 5, 2014

Release changed from v3.9 to v3.x

@wixbot wixbot added this to the v3.x milestone Dec 20, 2015
@rseanhall rseanhall added nativesdk and removed sdk labels Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants