New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable user to change setup language in Burn UI #5934
Comments
Implementation is ready, testing locally. |
Please, please, please don't just show up with a PR for a feature with implications this large. Please read through our development guide: http://wixtoolset.org/development/ how to get started. |
Yes I have read it and I thought rather than describing how I'm going to implement it, I'd better share what I already have. I'm still fighting with test suite and trying to revive all the former VS versions on my machine, which MSBuild for some reason doesn't detect, but debug code works, and I consider it good enough to present for review. |
You should know we're not taking new functionality into WiX v3.x so you'll want to target WiX v4 Burn. These are the things we would have discussed before sending a PR. |
No, I'm afraid I don't want to target WiX 4 any time soon. I'll leave the code in my fork then, in case someone is interested. |
That's totally fine (note: to be compliant with the OSS license you do need to publish any changes you make to the WiX Toolset, so your fork serves that purpose as well). If you'd like to see this feature in future releases of WiX and not have to maintain your fork forever, then it'd be good to discuss it as per the development guide: http://wixtoolset.org/development/ |
A little HowTo
|
@denis-gz code is not building at VS 2019, |
@py2901 This happened to me and to fix it I installed Windows SDK 10.0.17134.0, and .NET Framework 4. I'm using Visual Studio 2017. |
As of Wix 3.11, it is possible to create localized versions of Burn installer and present UI in user's language, detected from system settings. However, there are no means to change language selection in installer's UI, for whatever reason it might be needed. The only way now to switch to another language is to run the installer with the "-lang" option, which is not obvious for an average user. Or, one could change their system settings temporary, but it's not always possible and requires some experience as well.
The best solution to this inability would be to extend theme support in WixStdBA module, to include some combo-box control presenting the list of languages. For this to work, the package developer will need to adjust the theme to include names of all available localizations, set size and position, and set a flag (attribute) to enable the control. The user then would be able to make language selection on the fly, without the need to restart installer.
The text was updated successfully, but these errors were encountered: