Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Burn update detection should supply hashes if present in update feed #6353

Closed
barnson opened this issue Feb 11, 2021 · 0 comments · Fixed by wixtoolset/wix#240
Closed

Burn update detection should supply hashes if present in update feed #6353

barnson opened this issue Feb 11, 2021 · 0 comments · Fixed by wixtoolset/wix#240
Assignees
@barnson
Labels
burn
Projects
wix.4.0-preview.1
Milestone
v4.0

Comments

@barnson
Copy link
Member

barnson commented Feb 11, 2021

  • Describe the scenario and benefits that the feature supports.

Today, the update detection via OnDetectUpdate* doesn't pass the hashes (if any) contained in an update feed. IBootstrapperEngine::SetUpdate lets you specify a hash (though only SHA-1) so parts of the engine support it.

  • Describe how you're accomplishing the feature today (if possible).

Manually.

  • Describe what you'd like the new feature to do.

Automate the manual.
@barnson barnson added the triage label Feb 11, 2021
@barnson barnson changed the title Burn update detection should verify the downloaded bundle update Burn update detection should supply hashes if present in update feed Feb 11, 2021
@barnson barnson self-assigned this Feb 18, 2021
@barnson barnson added burn and removed triage labels Feb 18, 2021
@barnson barnson added this to the v4.0 milestone Feb 18, 2021
@barnson barnson added this to To do in wix.4.0-preview.1 via automation Aug 5, 2021
barnson added a commit to wixtoolset/wix that referenced this issue Aug 31, 2022
@barnson
Supply hashes to BA if present in update feed.
23f4ebf 
Fixes wixtoolset/issues#6353.
@barnson barnson mentioned this issue Aug 31, 2022
Merged
barnson added a commit to wixtoolset/wix that referenced this issue Aug 31, 2022
@barnson
Supply hashes to BA if present in update feed.
eb864d9 
Fixes wixtoolset/issues#6353.
barnson added a commit to wixtoolset/wix that referenced this issue Aug 31, 2022
@barnson
Supply hashes to BA if present in update feed.
914a92d 
Fixes wixtoolset/issues#6353.
wix.4.0-preview.1 automation moved this from To do to Done Aug 31, 2022
@barnson barnson mentioned this issue Sep 1, 2022
Closed
rseanhall pushed a commit to rseanhall/wix4 that referenced this issue Sep 2, 2022
@barnson @rseanhall
Supply hashes to BA if present in update feed.
bc10e0a 
Fixes wixtoolset/issues#6353.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barnson barnson

Labels
burn
Projects
No open projects
wix.4.0-preview.1
Done
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Supply hashes to BA if present in update feed. wixtoolset/wix
1 participant
@barnson