Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final .nupkgs contain duplicate native binaries #6460

Closed
robmen opened this issue May 25, 2021 · 0 comments · Fixed by wixtoolset/wix#118
Closed

Final .nupkgs contain duplicate native binaries #6460

robmen opened this issue May 25, 2021 · 0 comments · Fixed by wixtoolset/wix#118
Assignees
Milestone

Comments

@robmen
Copy link
Member

robmen commented May 25, 2021

Bugs

If this issue is a bug:

  • Which version of WiX are you building with?

v4-preview.1-build-latest

  • Which version of Visual Studio are you building with (if any)?

N/A

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

N/A

  • Which version of .NET are you building with?

N/A

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

N/A

  • Describe the problem and the steps to reproduce it.

In the move to a mon-repo, native binaries (wixnative.exe, wixnative.pdb and mergemod.dll) are duplicated in the final wix and WixToolset.Sdk .nupkgs:

a) in the runtimes folder (this is the expected location for production)
b) beside the managed code (this is the unexpected copy, used by unit tests but not production)

  • Describe the behavior you expected and how it differed from the actual behavior.

Native binaries should not be duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants