Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowsInstallerValidation target runs even when CoreCompile is up to date #6853

Closed
robmen opened this issue Aug 5, 2022 · 0 comments · Fixed by wixtoolset/wix#263
Closed

WindowsInstallerValidation target runs even when CoreCompile is up to date #6853

robmen opened this issue Aug 5, 2022 · 0 comments · Fixed by wixtoolset/wix#263
Assignees
@robmen
Labels
msbuild
Milestone
v4.0

Comments

@robmen
Copy link
Member

robmen commented Aug 5, 2022

Encountered at: wixtoolset/wix@16ed873f

Detail:

The WindowsInstallerValidation target has no Inputs/Outputs and so it will always run at the end of the Compile target. The WindowsInstallerValidation target can take a decent bit of time so it would be ideal if it only ran when the target package or module is updated.
@robmen robmen added the triage label Aug 5, 2022
@barnson barnson added msbuild and removed triage labels Aug 11, 2022
@barnson barnson added this to the v4.0 milestone Aug 11, 2022
@robmen robmen self-assigned this Oct 4, 2022
@robmen robmen mentioned this issue Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmen robmen

Labels
msbuild
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

Multiple MSBuild fixes wixtoolset/wix
2 participants
@robmen @barnson