Merge modules fail to build when intermediate path contains spaces

[iwarp]

Triage

Issues are triaged at online meetings, generally held alternate Thursdays at 9:30 a.m. Pacific time (UTC-7/UTC-8). Meeting requests are sent to the wix-devs and wix-users mailing lists, as well as in Discussions.

Discussions and support

Note that discussions are best held on the mailing lists not in issues. Please do not open issues requesting support or debugging help; first start a thread on the wix-users mailing list and open an issue if the discussion suggests a bug in the WiX Toolset or that a feature request is appropriate. You can also try out the beta Discussions feature.

Instructions

Read the sections above. Delete the Triage, Discussions and support, and Instructions sections and fill out the rest.

Bugs

If this issue is a bug:

• Which version of WiX are you building with?

4.0.0-rc.4+dea44a7d

• Which version of Visual Studio are you building with (if any)?

VS 2022 Community 17.5.2

• Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

0.9.5

• Which version of .NET are you building with?

4.8

• If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

Windows 11 22621.1413

• Describe the problem and the steps to reproduce it.

(Be as specific as you can and err on the side of providing too much information, including code, error messages, command lines you used to invoke the build, and so forth.)

• Describe the behavior you expected and how it differed from the actual behavior.

I have been upgrading my Wix3 project to Wix4, I have 3 Merge Modules for VC++ Redistributables. Building from msbuild in my build pipeline and via VS2022 Right Click Build. I end up with the following error

wix.exe : error WIX0017: Failed to extract cab 'C:\Subversion\Trunk Clean\SetupMSI\obj\x86\Debug\VCRedist2017.cab' from merge module 'Redists\Microsoft_VC140_CRT_x86.msm' to directory 'C:\Subversion\Trunk Clean\SetupMSI\obj\x86\Debug\VCRedist2017'. This is most likely due to a lack of available disk space on the destination drive

Running "wix build test.wxs" successfully builds the MSI, I've tracked this down to the -intermediatefolder flag, appending this to the build caused this to fail. "wix build mergetest.wxs -intermediatefolder obj\x86\Debug"

Example: test.wxs

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
	<Package Name="Test" Version="1.2.3.4" UpgradeCode="FA6768C3-9010-4B20-B03F-F3FC751F3A26" Manufacturer="Test">
		<Media Id="1" Cabinet="data.cab" EmbedCab="yes" />
		<Feature Id="VCRedist2017Feature" Title="Visual C++ 14.0 (2015, 2017, 2019) Runtime" Level="1" AllowAdvertise="no" Description="Supporting Libraries for Helix.">
			<MergeRef Id="VCRedist2017" />
		</Feature>
		<DirectoryRef Id="TARGETDIR">
			<Merge Id="VCRedist2017" SourceFile="Redists\Microsoft_VC140_CRT_x86.msm" DiskId="1" Language="0" />
		</DirectoryRef>
	</Package>
</Wix>

The error message here is hiding the underlying error, adding some additional debugging into src\wix\WixToolset.Core.WindowsInstaller\Bind\ExtractMergeModuleFilesCommand.cs line 216.

I get the following underlying error:
wixnative.exe failed with error code: -2147467259 - The filename, directory name, or volume label syntax is incorrect. Output:
api_ms_win_core_console_l1_1_0.dll.41084701_5F61_3497_AC5D_D0A6D4A85536

I'm unable to trace this in the code base well enough to find the source of this error.

I can upload the msm if required.

[barnson]

Doesn't repro on Win10. Can you push a repo with the necessary files and steps to repro?

[iwarp]

Hi @barnson, worked out how to repo it, the folder path c:\git\wix4-msm-bug\ works

But if you introduce a space into the name at any level of the parent folder, eg c:\git\wix4 msm bug\ if fails.

[iwarp]

Repo for Repro - https://github.com/iwarp/wix4-msm-bug