WIXBUG:4474 #115
Merged
WIXBUG:4474 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing headers; relocate headers to sdk\inc; add missing file and correct typo to point to deputil directory.
| @@ -29,8 +29,8 @@ | |||
|
|
|||
| <Fragment> | |||
| <DirectoryRef Id="SdkFolder"> | |||
| <Directory Id="SdkIncFolder" Name="inc" /> | |||
There was a problem hiding this comment.
This will cause the MSIs to share the headers, true? Okay with that?
There was a problem hiding this comment.
Yeah, I played around with it a bit. (Even installed Dev11 to get at least two SKUs!) Obviously, generated GUIDs work like a charm. They're sharing well.
There was a problem hiding this comment.
Yeah, wasn't worried about that part. More than we are doing this now. Anyway, I'll wait on thread on wix-devs. If all looks good, this will go for the RC2.
| <Directory Id="VisualStudioTargetSdkFolder" Name ="VS$(var.VisualStudioTargetVersion)"> | ||
| <Directory Id="SdkIncFolder" Name="inc" /> | ||
| <Directory Id="VisualStudioTargetSdkFolder" Name="VS$(var.VisualStudioTargetVersion)"> | ||
| <Directory Id="SdkIncFolder" Name="inc" /> |
There was a problem hiding this comment.
I don't follow what's happening here. Is this just a spacing change? If so, it doesn't quite look right...
There was a problem hiding this comment.
Sorry, didn't indent when I undid the folder move.
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing headers; relocate headers to sdk\inc; add missing file and
correct typo to point to deputil directory.