WIXBUG #4461 UriProtocol function is case sensitive #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion in dutil protocol strings are now compared case insensitive and the ftp scheme was incorrectly being mapped to URI_PROCOL::URI_PROTOCOL_FILE WIXBUG:4461 UriProtocol function is case sensitive incorporated feedback from previous pull request, re-submit as a single commit
|
Before we could accept your pull request, we need an assignment agreement on file. Please see the details at http://wixtoolset.org/development/. |
|
I have signed and received confirmation I have completed the "'Outercurve Foundation Assignment Agreement - WiX'" on 8/15/2104. |
| @@ -32,6 +32,11 @@ | |||
| <ProjectAdditionalIncludeDirectories>$(WixRoot)src\libs\dutil\inc</ProjectAdditionalIncludeDirectories> | |||
| <ProjectAdditionalLinkLibraries>rpcrt4.lib;dutil.lib</ProjectAdditionalLinkLibraries> | |||
| </PropertyGroup> | |||
| <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'"> | |||
| <Link> | |||
| <AdditionalDependencies>urlmon.lib;wininet.lib;%(AdditionalDependencies)</AdditionalDependencies> | |||
There was a problem hiding this comment.
To stay consistent with the rest of the vcxproj's in WiX, please move these into the ProjectAdditionalLinkLibraries property. As it's written right now, it would fail to build in any configuration except Debug|Win32.
There was a problem hiding this comment.
@rseanhall You are correct, I'm pushing up the fix shortly...
…property, not specific to Debug|Win32 configuration
robmen
added a commit
that referenced
this pull request
May 23, 2015
WIXBUG #4461 UriProtocol function is case sensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created tests for and corrected two issues with the UriProtocol function in dutil
protocol strings are now compared case insensitive and the ftp scheme was incorrectly being mapped to URI_PROCOL::URI_PROTOCOL_FILE
WIXBUG:4461 UriProtocol function is case sensitive
incorporated feedback from previous pull request, re-submit as a single commit