Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to edit suggested files don't work when running WoL on Windows #164

Closed
Adrodoc opened this issue Apr 2, 2018 · 2 comments
Closed

Links to edit suggested files don't work when running WoL on Windows #164

Adrodoc opened this issue Apr 2, 2018 · 2 comments
Assignees
@mkarneim
Labels
bug
Milestone
2.0.0

Comments

@Adrodoc
Copy link
Member

Adrodoc commented Apr 2, 2018

On Windows the file seperator is \. Because of this the paths suggested by tabcompletion of commands like /wol file edit contain \. A \ is not allowed in an URL and so the URL that is printed in the chat is not clickable. We should either suggest paths containing / or replace all \ before printing the URL in the chat.
@Adrodoc Adrodoc added the bug label Apr 2, 2018
@mkarneim mkarneim added this to the 2.0.0 milestone Apr 13, 2018
@mkarneim mkarneim self-assigned this Apr 14, 2018
@mkarneim
Copy link
Member

@Adrodoc55 , may I ask you to test the supplied fix since I have no access to MS Windows?

@Adrodoc
Copy link
Member Author

Adrodoc commented Apr 14, 2018

@mkarneim I can confirm, that the bug is fixed on branch fix/#164 (in 69fb380)

mkarneim added a commit that referenced this issue Apr 26, 2018
@mkarneim
Merge branch 'fix/#164' into devel
2f2b219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarneim mkarneim

Labels
bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@mkarneim @Adrodoc