-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] Installer - Add Electrum node option #1241
Conversation
06ce674
to
7babcb9
Compare
I made a further change to the behaviour while checking the connection. It's safer to prevent the user editing config values until the connection check completes to ensure the values don't change in the meanwhile, which could mean the connection status applies to the wrong values. I think this was already an issue with the current installer but I guess connection checks are usually quicker with a local bitcoind and so it was less likely to cause problems. |
7babcb9
to
78c7115
Compare
I updated the liana dependency commit. |
@nondiremanuel I made minor wording changes to the following page to mention Electrum: Then on the next page, the user can choose the node type: Perhaps I should remove "full" from the title of this page. |
For the first page, I was proposing to take the opportunity to make the text simpler and more understandable (at least in my view):
If there is no consensus with this, we can also leave it as you did (i.e. adding the Electrum mentions) and discuss the general wording for another time. The second page was exactly what I had in mind. Thanks! |
78c7115
to
de9d7d5
Compare
I've updated the wording as suggested with some minor changes:
I removed "full" from the title: |
30 GB looks more correct to me (signet chain included but it's only 2.2GB): ~/.liana/bitcoind ❯ sudo du datadir -sh
29G datadir |
i'm wondering about one thing here, did the address still only accept ip addresses? |
tested on linux adding |
de9d7d5
to
c135055
Compare
I've made the suggested changes. I now need to rebase on master as there's a conflict. |
Thanks for testing that. Yep, currently the Liana config file accepts any string, which is the same as the underlying Electrum client. Whether we allow any string or not might change as part of #1222. |
c135055
to
3140b9b
Compare
Rebased on master. |
3140b9b
to
d04b535
Compare
Sorry, I made a further change to the Electrum address validation. |
d04b535
to
8d8397e
Compare
Updated liana dependency commit hash. |
Maybe we can add (in a follow up) the name/type of the electrum server (by sending a |
e7904c2
to
b01029c
Compare
Updated liana dependency commit hash. |
b01029c
to
8f5225c
Compare
Added a commit to enable changing from one node type to another in the settings. Note that in its current form, it'll be possible for someone who's using managed bitcoind to switch to Electrum in the settings. In this case, the GUI will not try to start the managed bitcoind the next time they launch the GUI. I could also prevent such a user from switching node type (indeed, they cannot edit the bitcoind settings currently). I also made a fix to a previous commit so that we take into account whether a rescan is in progress in order to determine whether the Electrum settings can be edited. |
8f5225c
to
083bbf1
Compare
083bbf1
to
819eb92
Compare
ACK 819eb92 |
0f48db7 electrum: check connectivity before creating client (Michael Mallan) Pull request description: This is to resolve #1276. Tested that this change stops GUI freezing in #1241 when using invalid address in Electrum settings. ACKs for top commit: darosior: utACK 0f48db7 Tree-SHA512: b176ceafda887c4ef97110c6a87807787136da6fd67fb8a2af0b63c102a7d0145f46df5d75b61a10b45cf4cbc91ad27535de7abaf13409e259d1c75881abcef3
This is for #1223.
For now, it's possible to edit the node's settings but not to change node type.
Remaining tasks: