Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nanobind methods on non-nanobind classes. #104

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Allow nanobind methods on non-nanobind classes. #104

merged 1 commit into from
Dec 5, 2022

Commits on Dec 5, 2022

  1. Allow nanobind methods on non-nanobind classes. 

    This allows us to extend an existing Python (or
pybind11!) class with methods defined in nanobind. This is handy if you
want to add a small amount of nanobind code to a class
defined in other ways. For example, one use is to migrate methods of a
pybind11-defined class to nanobind one by one.

All we have to do to allow this is remove the type check. I
can't see anything that goes wrong if we simply allow dispatch to
proceed.
    @hawkinsp
    hawkinsp committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    566f7f5 View commit details
    Browse the repository at this point in the history