Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bool ndarray #150

Merged
merged 1 commit into from Mar 26, 2023
Merged

Support bool ndarray #150

merged 1 commit into from Mar 26, 2023

Conversation

yosh-matsuda
Copy link
Contributor

This pull request adds support for bool ndarray. The bool type was introduced in DLPack v0.8.

The changes are ad follows:

  • Add bool type to dtype code
  • Add tests for NumPy, TensorFlow, and JAX.
    • PyTorch does not seem to support the bool type yet (?)

@wjakob Could you review this?

@wjakob
Copy link
Owner

wjakob commented Mar 26, 2023

This looks fantastic! I will merge it as-is, thanks.

@wjakob wjakob merged commit 989c796 into wjakob:master Mar 26, 2023
16 checks passed
@yosh-matsuda
Copy link
Contributor Author

@wjakob Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yosh-matsuda @wjakob