nb::handle: make bool conversion explicit to avoid ambiguity with integer conversions in derived types #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
explicit operator bool()
can still be used in conditional tests without a cast (if (h) { ... }
) and is a better match for the explicitness of, for example,operator int()
innb::int_
. Without this change, if you writethen
fn(nb::int_(42))
will print 1. (Only implicit conversions are allowed by the initialization style used, so the implicitoperator bool
innb::handle
is eligible while the explicitoperator int
innb::int_
is not.)