New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix naming of ABI3 extension libraries on Windows #222
Conversation
ae87fe8
to
ca36a89
Compare
I'd recommend basing this on the existence of these variables, rather than the CMake version, because scikit-build-core has 3.26's FindPython even on 3.15 (unless a user disables it). |
Though I guess |
a583bef
to
0a452aa
Compare
ok will do.
|
This commit fixes the naming conventions of ABI3 builds on Windows. It also adopts a recent CMake/FindPython interface whenever available.
Merging in favor of #221. |
This commit fixes the naming conventions of ABI3 builds on Windows. It also adopts a recent CMake/FindPython interface whenever available.