Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of ABI3 extension libraries on Windows #222

Merged
merged 2 commits into from May 31, 2023
Merged

Conversation

wjakob
Copy link
Owner

@wjakob wjakob commented May 31, 2023

This commit fixes the naming conventions of ABI3 builds on Windows. It also adopts a recent CMake/FindPython interface whenever available.

@wjakob wjakob force-pushed the abi3-filename branch 2 times, most recently from ae87fe8 to ca36a89 Compare May 31, 2023 20:35
@henryiii
Copy link
Contributor

I'd recommend basing this on the existence of these variables, rather than the CMake version, because scikit-build-core has 3.26's FindPython even on 3.15 (unless a user disables it).

@henryiii
Copy link
Contributor

henryiii commented May 31, 2023

Though I guess Python_SOABI was incorrect for PyPy until 3.26 as well. Generally I’d try to avoid calling Python, as it could be incorrect if you are cross compiling, and it's slower than just using a value. Maybe just use these values if they are defined unless it's PyPy & older CMake? (very minor issue)

@wjakob wjakob force-pushed the abi3-filename branch 2 times, most recently from a583bef to 0a452aa Compare May 31, 2023 20:46
@wjakob
Copy link
Owner Author

wjakob commented May 31, 2023

I'd recommend basing this on the existence of these variables [..]

ok will do.

Python_SOABI seems not to include the final part of the extension (.dll / .so). Is there a portable way to get that? I am asking because of the inconsistency on macOS, where .so is used instead of .dylib.

This commit fixes the naming conventions of ABI3 builds on Windows. It
also adopts a recent CMake/FindPython interface whenever available.
@wjakob
Copy link
Owner Author

wjakob commented May 31, 2023

Merging in favor of #221.

@wjakob wjakob merged commit da61970 into master May 31, 2023
16 checks passed
@wjakob wjakob deleted the abi3-filename branch May 31, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants