Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nb::globals #311

Merged
merged 10 commits into from Oct 6, 2023
Merged

add nb::globals #311

merged 10 commits into from Oct 6, 2023

Conversation

nschloe
Copy link
Contributor

@nschloe nschloe commented Oct 3, 2023

No description provided.

@nschloe nschloe marked this pull request as draft October 3, 2023 15:34
@nschloe nschloe marked this pull request as ready for review October 3, 2023 15:35
wjakob
wjakob requested changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@wjakob wjakob left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have two small change requests.

include/nanobind/nb_globals.h Outdated Show resolved Hide resolved
@nschloe nschloe requested a review from wjakob October 3, 2023 18:16
@nschloe
Copy link
Contributor Author

nschloe commented Oct 3, 2023

The test failure is unrelated I believe.

@nschloe nschloe requested a review from wjakob October 5, 2023 09:44
wjakob
wjakob reviewed Oct 5, 2023
View reviewed changes
include/nanobind/nb_misc.h Outdated Show resolved Hide resolved
@wjakob wjakob force-pushed the master branch 2 times, most recently from a375ccd to 7e4a88b Compare October 5, 2023 23:19
@wjakob wjakob merged commit 8d565a1 into wjakob:master Oct 6, 2023
21 checks passed
wjakob pushed a commit that referenced this pull request Oct 6, 2023
@nschloe @wjakob
added nb::globals() function wrapping PyEval_GetGlobals() (#311)
11af926
wjakob pushed a commit that referenced this pull request Oct 6, 2023
@nschloe @wjakob
added nb::globals() function wrapping PyEval_GetGlobals() (#311)
57a6ff0
@wjakob
Copy link
Owner

wjakob commented Oct 6, 2023

I made a small change: nb::detail::raise_python_error() did not apply since PyEval_GetGlobals does not set a Python error status when it returns NULL..

@wjakob
Copy link
Owner

wjakob commented Oct 6, 2023

(also, this is a new feature rather than a bugfix, so it will go into the next minor release, not the patch one.)

@nschloe nschloe deleted the globals branch October 6, 2023 10:29
wjakob pushed a commit that referenced this pull request Oct 6, 2023
@nschloe @wjakob
added nb::globals() function wrapping PyEval_GetGlobals() (#311)
f0a9ebd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjakob wjakob wjakob requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nschloe @wjakob