hww weakref2 #335
Merged
hww weakref2 #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
force-pushed
the
master
branch
4 times, most recently
from
ddb2a3e
to
3c2b64a
Compare
|
Just a quick note: I haven't forgotten about this commit and plan to work on merging it -- not in the next release, but in the one after that. |
|
Thank you @huangweiwu -- I finally had a chance to review this PR, and it looks perfect as-is. I committed it with very minor formatting touchups. |
wjakob
pushed a commit
that referenced
this pull request
Feb 18, 2024
The logic closely follows that of internal attribute dictionaries and involves an additional pointer to store a weak reference list.
wjakob
pushed a commit
that referenced
this pull request
Feb 18, 2024
The logic closely follows that of internal attribute dictionaries and involves an additional pointer to store a weak reference list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve conflict