Avoid a crash in nb::try_cast<T>(nb::none()) #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oremanj
force-pushed
the
try-cast-except
branch
from
ab13f0d
to
b46c92b
Compare
wjakob
reviewed
Dec 15, 2023
include/nanobind/nb_cast.h
Outdated
| try { | ||
| out = caster.operator detail::cast_t<T>(); | ||
| return true; | ||
| } catch (...) { |
There was a problem hiding this comment.
Can you be more specific in catching a particular exception here? I think it should be nb::next_overload.
There was a problem hiding this comment.
Sure. It's nb::builtin_exception since all the more-specific choices turned into wrappers around that one.
oremanj
force-pushed
the
try-cast-except
branch
from
d28d3ca
to
d5bc6bf
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it could raise an exception from the
type_caster's conversion operator, which would then crash the program due totry_castbeingnoexcept.