Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serial.vcxproj: AdditionalIncludeDirectories relative for solution not project #105

Closed
ramirahikkala opened this issue Aug 13, 2015 · 1 comment
Closed

serial.vcxproj: AdditionalIncludeDirectories relative for solution not project #105

ramirahikkala opened this issue Aug 13, 2015 · 1 comment

Comments

@ramirahikkala
Copy link
Contributor

If I add serial.vcxproj to my solution header files cannot be found. AdditionalIncludeDirectories should be relative for project to make it possible to add project to other solutions too.

It is now like this:
$(SolutionDir)..\include;%(AdditionalIncludeDirectories)
Should be:
$(ProjectDir)....\include;%(AdditionalIncludeDirectories)
@wjwwood
Copy link
Owner

wjwwood commented Aug 13, 2015

Thanks for pointing that out! Can you open a pull request to that effect? That way it will attributed to you and our CI can automatically test it.

ramirahikkala pushed a commit to ramirahikkala/serial that referenced this issue Aug 14, 2015
AdditionalIncludeDirectories must be relative for project not solution
cd5053c 
Fixes wjwwood#105

Signed-off-by: Rami <rami.rahikkala@jotautomation.com>
@ramirahikkala ramirahikkala mentioned this issue Aug 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wjwwood @ramirahikkala