-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to most recent versions of Elixir / packages / CI #14
base: master
Are you sure you want to change the base?
Conversation
Problem: - recent Elixir compiler emits warnings on function calls without parenthesis Solution: - call functions with parenthesis
Problem: - current code requires manual formatting Solution: - create the config for the Elixir formatter to be called by `mix format`
It's a little bit brutal PR because I have introduced a formatter config. Also it is recommended to switch to Github Actions, because travis might not offer their OSS service for much longer. My motivation was to fix compilation warnings, and it kinda snowballed from it to this. Feel free to close this PR and cherry-pick changes that you feel are useful. 😄 |
Test are passing here: https://github.com/happycodrz/webassembly/actions |
Hey! Good job I think CI changes +1 Formatter: yeah WebAssembly was done during wild wild west years, where it was common to use paren-less calls.. I guess me as well as Jose and large part of the community got annoyed by it at pretty much the same time. I only need to get used to formatter changes of DSL itself. But why not. Aaaand, I'd need to recreate my Elixir dev env, as I don't code in it nowadays. Please ping me if I wouldn't do anything with this PR in a couple (literally: couple) of days |
@wkhere OK, will ping you next week Wednesday. This gives you this weekend and half week next week. Hope your Elixir dev env re-creation will workout smoothly. I use https://github.com/asdf-vm/asdf and wholeheartedly recommend it. It saves you from going mad between conflicting versions.
|
@wkhere Keeping my promise - ping... |
ping (2nd) |
No description provided.