Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to most recent versions of Elixir / packages / CI #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mindreframer
Copy link
Contributor

No description provided.

Problem: 
- recent Elixir compiler emits warnings on function calls without parenthesis

Solution: 
- call functions with parenthesis
Problem: 
- current code requires manual formatting

Solution: 
- create the config for the Elixir formatter to be called by `mix format`
@mindreframer
Copy link
Contributor Author

It's a little bit brutal PR because I have introduced a formatter config.

Also it is recommended to switch to Github Actions, because travis might not offer their OSS service for much longer.

My motivation was to fix compilation warnings, and it kinda snowballed from it to this. Feel free to close this PR and cherry-pick changes that you feel are useful.
Its funny that its again Jan (after my last PR)

😄

@mindreframer
Copy link
Contributor Author

Test are passing here: https://github.com/happycodrz/webassembly/actions

@wkhere
Copy link
Owner

wkhere commented Jan 14, 2021

Hey! Good job I think

CI changes +1

Formatter: yeah WebAssembly was done during wild wild west years, where it was common to use paren-less calls.. I guess me as well as Jose and large part of the community got annoyed by it at pretty much the same time.

I only need to get used to formatter changes of DSL itself. But why not.

Aaaand, I'd need to recreate my Elixir dev env, as I don't code in it nowadays. Please ping me if I wouldn't do anything with this PR in a couple (literally: couple) of days

@mindreframer
Copy link
Contributor Author

@wkhere OK, will ping you next week Wednesday. This gives you this weekend and half week next week. Hope your Elixir dev env re-creation will workout smoothly. I use https://github.com/asdf-vm/asdf and wholeheartedly recommend it. It saves you from going mad between conflicting versions.

$ asdf list
direnv
  2.21.3
elixir
  1.10.4-otp-23
  1.11.0-otp-23
  1.11.2-otp-23
erlang
  23.0.1
golang
  1.14.4
nim
  1.2.4
nodejs
  12.18.2
ruby
  2.7.0

@mindreframer
Copy link
Contributor Author

@wkhere Keeping my promise - ping...

@mindreframer
Copy link
Contributor Author

ping (2nd)

@wkhere wkhere reopened this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants