Skip to content

Commit

Permalink
pkg/cli/admin/upgrade: Delegate to update-approvers
Browse files Browse the repository at this point in the history
This subcommand interacts with the cluster-version operator, which is
now maintained by the updates team.  I'm seeding the alias with the
content from [1].  I've left the 'component' property (added to the
root OWNERS in e83f2ac, Add BZ component name to OWNERS,
2020-04-03, openshift#367) off for now, because the tooling around that only
consumes entries at the repo level.

I think that the admin/release should also be maintained by the
updates team, because it manages the release images for which the CVO
is the sole consumer.  But Scott wants to punt on that for now.

[1]: https://github.com/openshift/cluster-version-operator/blob/914467c03b5bc25dbe4c9295c420fdb2598db821/OWNERS
  • Loading branch information
wking committed Apr 17, 2020
1 parent cd553d0 commit 2abda3a
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
11 changes: 11 additions & 0 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES

aliases:
update-approvers:
- abhinavdahiya
- crawford
- jottofar
- sdodson
- smarterclayton
- vrutkovs
- wking
5 changes: 5 additions & 0 deletions pkg/cli/admin/upgrade/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- update-approvers

0 comments on commit 2abda3a

Please sign in to comment.