Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BZ component name to OWNERS #367

Merged
merged 1 commit into from Apr 6, 2020

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Apr 3, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020
@soltysh
Copy link
Member Author

soltysh commented Apr 6, 2020

/retest

@sallyom
Copy link
Contributor

sallyom commented Apr 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f2b01c4 into openshift:master Apr 6, 2020
@soltysh soltysh deleted the component_name branch April 8, 2020 18:08
wking added a commit to wking/oc that referenced this pull request Apr 17, 2020
These to subcommands interact with the cluster-version operator, which
is now maintained by the updates team.  I'm seeding the alias with the
content from [1].  I've left the 'component' property (added to the
root OWNERS in e83f2ac, Add BZ component name to OWNERS,
2020-04-03, openshift#367) off for now, because the tooling around that only
consumes entries at the repo level.

[1]: https://github.com/openshift/cluster-version-operator/blob/914467c03b5bc25dbe4c9295c420fdb2598db821/OWNERS
wking added a commit to wking/oc that referenced this pull request Apr 17, 2020
This subcommand interacts with the cluster-version operator, which is
now maintained by the updates team.  I'm seeding the alias with the
content from [1].  I've left the 'component' property (added to the
root OWNERS in e83f2ac, Add BZ component name to OWNERS,
2020-04-03, openshift#367) off for now, because the tooling around that only
consumes entries at the repo level.

I think that the admin/release should also be maintained by the
updates team, because it manages the release images for which the CVO
is the sole consumer.  But Scott wants to punt on that for now.

[1]: https://github.com/openshift/cluster-version-operator/blob/914467c03b5bc25dbe4c9295c420fdb2598db821/OWNERS
wking added a commit to wking/oc that referenced this pull request Apr 17, 2020
This subcommand interacts with the cluster-version operator, which is
now maintained by the updates team.  I'm seeding the alias with the
content from [1].  I've left the 'component' property (added to the
root OWNERS in e83f2ac, Add BZ component name to OWNERS,
2020-04-03, openshift#367) off for now, because the tooling around that only
consumes entries at the repo level.

I think that the admin/release should also be maintained by the
updates team, because it manages the release images for which the CVO
is the sole consumer.  But Scott wants to punt on that for now.

[1]: https://github.com/openshift/cluster-version-operator/blob/914467c03b5bc25dbe4c9295c420fdb2598db821/OWNERS
wking added a commit to wking/oc that referenced this pull request Apr 17, 2020
This subcommand interacts with the cluster-version operator, which is
now maintained by the updates team.  I'm seeding the alias with the
content from [1] (and adding Lala, who's the team lead).  I've left
the 'component' property (added to the root OWNERS in e83f2ac, Add
BZ component name to OWNERS, 2020-04-03, openshift#367) off for now, because
the tooling around that only consumes entries at the repo level.

I think that the admin/release should also be maintained by the
updates team, because it manages the release images for which the CVO
is the sole consumer.  But Scott wants to punt on that for now.

[1]: https://github.com/openshift/cluster-version-operator/blob/914467c03b5bc25dbe4c9295c420fdb2598db821/OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants