Make elixir-ts-mode-hook a customizable variable

[sirikid]

No description provided.

[wkirschbaum]

@sirikid what problem are you trying to solve here? I have not seen this done on other modes and not sure what it achieves.

[sirikid]

@sirikid what problem are you trying to solve here? I have not seen this done on other modes and not sure what it achieves.

Language mode hooks are intended for user customization thus they should be accessible through Custom. I think most of the built-in hooks are customizable at this point.

[wkirschbaum]

@sirikid there is already a elixir-ts-mode hook which is part of deriving from prog-mode. what am I missing here?

You can already do something like this:

(add-hook 'elixir-ts-mode-hook (lambda () (subword-mode)))

[wkirschbaum]

I had a look at some other modes and saw lua-ts-mode is the only -ts-mode with this variable. Let me do some reason to see how it works. If you can give me an example it would also be great.

[sirikid]

I had a look at some other modes and saw lua-ts-mode is the only -ts-mode with this variable. Let me do some reason to see how it works. If you can give me an example it would also be great.

Custom is an Emacs subsystem for interactive customization. Here you can see my custom-file, generated by this system, and then a screenshot of the interface.

On the left is the customization of the hook and on the right is the customization of another variable with a relatively complex structure (alist).

[wkirschbaum]

I am guessing the proposed change allows you to use the customize menu instead of having to do it in your init.el file? Not many modes have this, so just trying to understand. The PR came with no motivation or description.

[sirikid]

I am guessing the proposed change allows you to use the customize menu instead of having to do it in your init.el file?

Yes.

Not many modes have this, so just trying to understand.

I had a different experience.

The PR came with no motivation or description.

Sorry, I thought it was a common knowledge.

[wkirschbaum]

Not many modes have this, so just trying to understand.

I had a different experience.

You can view the emacs source code and will find it is in only a handful of progmodes.

The PR came with no motivation or description.

Sorry, I thought it was a common knowledge.

Even so, its still good to give some motivation.

I can't see a reason not to add it after having a look. Please add an appropriate comment as below then I can merge:

(defcustom c-mode-hook nil
  "Hook called by `c-mode'."
  :type 'hook
  :group 'c)

You don't need the comment either.

[wkirschbaum]

"Hook run after entering `elixir-ts-mode'." its not Elixir mode.

[wkirschbaum]

The convention is to specify 'nil' here. Even though its the same it is still good to stick with conventions.

[wkirschbaum]

Please use the form '(eglot-ensure) as this seems to be the convention.