Skip to content

Commit

Permalink
Merge pull request #18 from ethanbass/check-namespace
Browse files Browse the repository at this point in the history
Implementing check-namespace function when reading in mzML, needs testing
  • Loading branch information
wkumler committed Nov 13, 2023
2 parents 3ffa687 + e5545c8 commit 3f5bc06
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions R/grabMSdataCode.R
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,8 @@ checkOutputQuality <- function(output_data, grab_what){
#' plot(tic$rt, tic$int, type = "l")
grabAccessionData <- function(filename, accession_number){
xml_data <- xml2::read_xml(filename)

checkNamespace(xml_data)
arb_xpath <- paste0('//d1:cvParam[@accession="', accession_number, '"]')
arb_nodes <- xml2::xml_find_all(xml_data, arb_xpath)
out_df <- data.frame(name=xml2::xml_attr(arb_nodes, "name"),
Expand All @@ -359,6 +361,13 @@ grabAccessionData <- function(filename, accession_number){
}

# Other functions ----

checkNamespace <- function(xml_data){
if (is.na(xml2::xml_attr(xml_data,"xmlns"))){
xml2::xml_attr(xml_data,"xmlns") <- "http://psi.hupo.org/ms/mzml"
}
}

checkFileType <- function(xml_data, node_to_check){
# Check for mzML node
# Length works because external pointer has length 2
Expand Down
1 change: 1 addition & 0 deletions R/grabMzmlFunctions.R
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ grabMzmlData <- function(filename, grab_what, verbosity=0,
}
xml_data <- xml2::read_xml(filename)

checkNamespace(xml_data)
checkFileType(xml_data, "mzML")
rtrange <- checkRTrange(rtrange)
prefilter <- checkProvidedPrefilter(prefilter)
Expand Down

0 comments on commit 3f5bc06

Please sign in to comment.