Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check namespace when reading in mzML #18

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

ethanbass
Copy link
Contributor

I think this resolves the namespace issue mentioned in #17. Not sure if we should also call the checkNamespace function in grabMzxmlData. I only incorporated it here into grabMzmlData.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.13 ⚠️

Comparison is base (3ffa687) 85.31% compared to head (e5545c8) 85.19%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   85.31%   85.19%   -0.13%     
==========================================
  Files           5        5              
  Lines        1171     1175       +4     
==========================================
+ Hits          999     1001       +2     
- Misses        172      174       +2     
Impacted Files Coverage Δ
R/grabMSdataCode.R 87.56% <33.33%> (-0.90%) ⬇️
R/grabMzmlFunctions.R 93.03% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wkumler
Copy link
Owner

wkumler commented Apr 25, 2023

Neat! Thanks for putting in the work. I'll do some extra tests on my own shortly and check out the mzXML implementation and merge if it all looks okay.

@wkumler wkumler mentioned this pull request Nov 13, 2023
9 tasks
@wkumler wkumler changed the base branch from master to version_1.3.2 November 13, 2023 21:14
@wkumler wkumler merged commit 3f5bc06 into wkumler:version_1.3.2 Nov 13, 2023
3 checks passed
@ethanbass ethanbass deleted the check-namespace branch November 13, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants