Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream issue #11961: alternative de-duplication approach #1

Closed
wants to merge 16 commits into from
Closed

Upstream issue #11961: alternative de-duplication approach #1

wants to merge 16 commits into from

Commits on Feb 7, 2024

  1. Fix duplicate search results 

    We currently list the same page multiple times if,
for example, both the title and content search
match it. Since the preview is always the same,
this is not very helpful.
    @wlach @jayaddison
    wlach authored and jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1a0e6a3 View commit details
    Browse the repository at this point in the history

  2. Another approach

    @wlach @jayaddison
    wlach authored and jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    eea244f View commit details
    Browse the repository at this point in the history

  3. Review feedback

    @wlach @jayaddison
    wlach authored and jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6473d51 View commit details
    Browse the repository at this point in the history

  4. HTML Search: Add test, refactoring to make that possible

    @wlach @jayaddison
    wlach authored and jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d2648b2 View commit details
    Browse the repository at this point in the history

  5. Keep anchor, de-duplicate on less keys

    @wlach @jayaddison
    wlach authored and jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2d82cb7 View commit details
    Browse the repository at this point in the history

  6. De-duplicate on document title only

    @wlach @jayaddison
    wlach authored and jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5819346 View commit details
    Browse the repository at this point in the history

  7. experimentation: undo local fix attempt

    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    4208655 View commit details
    Browse the repository at this point in the history

  8. experimentation: undo test expectation change

    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    17da9b1 View commit details
    Browse the repository at this point in the history

  9. experimentation: alternative de-duplication method

    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    344274b View commit details
    Browse the repository at this point in the history

  10. experimentation: compared to original, omit only the title field from… 

    … the de-duplication string
    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a94ab83 View commit details
    Browse the repository at this point in the history

  11. experimentation: use jasmine.createSpy to avoid function contract cha… 

    …nges; currently requires enabling mutability of _displayNextItem - not great.
    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1f2eb3d View commit details
    Browse the repository at this point in the history

  12. cleanup: remove unnecessary '.and.returnValue' call-chain

    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2b7f49f View commit details
    Browse the repository at this point in the history

  13. experimentation: update test case to avoid dependency on fix from sph… 

    …inx-doc#11960
    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    04ad76a View commit details
    Browse the repository at this point in the history

  14. experimentation: apply patch derived from sphinx-doc#11959

    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    dcc3443 View commit details
    Browse the repository at this point in the history

  15. experimentation: expect anchor-less title result

    @jayaddison
    jayaddison committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e2d07a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. experimentation: cleanup: remove 'resultStr' de-dup key changes

    @jayaddison
    jayaddison committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    251bf95 View commit details
    Browse the repository at this point in the history