Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary keyword this from functions #56

Merged
merged 1 commit into from Nov 7, 2019

Conversation

wlsf82
Copy link
Owner

@wlsf82 wlsf82 commented Nov 7, 2019

Also, update the changelog and package patch version.

Pull Request Checklist

- [x] Have you followed the steps in our [Contributing](https://github.com/wlsf82/protractor-helper/blob/master/docs/CONTRIBUTING.md) document?
- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/wlsf82/protractor-helper/pulls) for the same update/change?
- [x] Have you successfully ran tests with your changes locally?
- [-] Have you written new tests for your changes, if necessary?
- [x] Have you added an explanation of what your changes do and why you'd like us to include them?
- [-] Have you made improvements to the documentation, if necessary? ([docs/](https://github.com/wlsf82/protractor-helper/tree/master/docs) folder and [README.md](https://github.com/wlsf82/protractor-helper/blob/master/README.md))
- [-] Have you linked the correct [GitHub issue](https://github.com/wlsf82/protractor-helper/issues), if there is any?

> Pull requests that do not pass the automated tests on [SemaphoreCI](http://semaphoreci.com) and the code quality verification on [Better Code Hub](https://bettercodehub.com/) will not be reviewed

Also, update the changelog and package patch version.
@wlsf82
Copy link
Owner Author

wlsf82 commented Nov 7, 2019

@PauloGoncalvesBH, would you mind reviewing this PR, please?

Copy link
Collaborator

@PauloGoncalvesBH PauloGoncalvesBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved :)

@wlsf82 wlsf82 merged commit 34ba2d0 into master Nov 7, 2019
@wlsf82 wlsf82 deleted the remove-unnecessary-keyword-this-from-functions branch November 7, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants