feat: Add timetable patterns #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This change stops our CSS leaking into other peoples websites when using our CSS. Things that have been changed are: Removing generic element selectors such as h1, h2, a etc. and replaced them with a wrapped [class*="wmnds-"], this ensures that we only apply styling to generic elements if it is a child of one of our design system classes Updated the generic h1, h2, h3, h4, h5, h6 classes so they are now prefixed with wmnds e.g. wmnds-h1, wmnds-h2 etc. Gone through all components and patterns to ensure any missing styles that were previously inheritted from generic styles are now part of the component styling itself. For instance if we had a p.wmnds-example that was reliant on the general element p margins, that component would have been updated to have the margins on the .wmnds-example class itself.
# [2.0.0](v1.8.0...v2.0.0) (2021-07-29) * feat!: Stopped design system CSS leaking on to other websites ([393f1fd](393f1fd)) ### BREAKING CHANGES * This change stops our CSS leaking into other peoples websites when using our CSS. Things that have been changed are: Removing generic element selectors such as h1, h2, a etc. and replaced them with a wrapped [class*="wmnds-"], this ensures that we only apply styling to generic elements if it is a child of one of our design system classes Updated the generic h1, h2, h3, h4, h5, h6 classes so they are now prefixed with wmnds e.g. wmnds-h1, wmnds-h2 etc. Gone through all components and patterns to ensure any missing styles that were previously inheritted from generic styles are now part of the component styling itself. For instance if we had a p.wmnds-example that was reliant on the general element p margins, that component would have been updated to have the margins on the .wmnds-example class itself.
fix: Updated github actions to use new branch names (#863)
fix: Added new "main" branch name to package json (#865)
…cadigital/wmn-design-system into hb/feat/timetable
|
🚀 Deployed on https://deploy-preview-877--wmnetwork.netlify.app |
jkmnch
suggested changes
Aug 25, 2021
There was a problem hiding this comment.
Hi Houston,
The expanded view window showing the next bus stops will need to have a set height, rather than showing all of the stops from the selected time, like how it currently works on the stop pages: https://legacy.wmnetwork.co.uk/plan-your-journey/stops/detail/#/stop=43000702303?operator=NXB&service=16&version=0&when=0&time=1540
@jkmnch Okay that's fine, I'm assuming the close button should be fixed to the top when scrolled? |
|
@houbly Yes please |
Merged
wmcadigital-admin
pushed a commit
that referenced
this pull request
Aug 26, 2021
# [2.1.0](v2.0.1...v2.1.0) (2021-08-26) ### Features * add autocomplete selected state ([#875](#875)) ([0e892ff](0e892ff)) * Add timetable patterns ([#877](#877)) ([cbee3f8](cbee3f8)) * added facilities icons ([#878](#878)) ([de557c0](de557c0)) * Adding shareable travel updates widget's documentation. ([#873](#873)) ([7110a99](7110a99))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gldgrnt
added a commit
that referenced
this pull request
Oct 18, 2021
* chore(release): 2.1.0 [skip ci] # [2.1.0](v2.0.1...v2.1.0) (2021-08-26) ### Features * add autocomplete selected state ([#875](#875)) ([0e892ff](0e892ff)) * Add timetable patterns ([#877](#877)) ([cbee3f8](cbee3f8)) * added facilities icons ([#878](#878)) ([de557c0](de557c0)) * Adding shareable travel updates widget's documentation. ([#873](#873)) ([7110a99](7110a99)) * Add page & copy * add facilities content & styling Co-authored-by: Gil <43111519+gldgrnt@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
gldgrnt
added a commit
that referenced
this pull request
Oct 18, 2021
* chore(release): 2.1.0 [skip ci] # [2.1.0](v2.0.1...v2.1.0) (2021-08-26) ### Features * add autocomplete selected state ([#875](#875)) ([0e892ff](0e892ff)) * Add timetable patterns ([#877](#877)) ([cbee3f8](cbee3f8)) * added facilities icons ([#878](#878)) ([de557c0](de557c0)) * Adding shareable travel updates widget's documentation. ([#873](#873)) ([7110a99](7110a99)) * Add page & copy * add find stops and stations widget * add nearest stop sidebar widget * add sidebar widgets * prevent anchor link scroll Co-authored-by: Gil <43111519+gldgrnt@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
wmcadigital-admin
pushed a commit
that referenced
this pull request
Oct 19, 2021
# [2.2.0](v2.1.0...v2.2.0) (2021-10-19) ### Features * add stops and stations patterns ([#887](#887)) ([39e2b43](39e2b43)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873) * add facilities pattern ([#886](#886)) ([c2f5de2](c2f5de2)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873) * add favourite action ([#888](#888)) ([01a9fdb](01a9fdb)) * add live departures patterns ([#885](#885)) ([0d87697](0d87697))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Bus and tram timetable
-- Train timetable
-- Bus and tram route
fixes Timetables for Stop/Station pages #870