Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stops and stations patterns #887

Merged
merged 9 commits into from
Oct 18, 2021

Conversation

houbly
Copy link
Contributor

@houbly houbly commented Oct 18, 2021

Add find a stop or station patterns
fixes #867

gldgrnt and others added 6 commits August 26, 2021 10:06
# [2.1.0](v2.0.1...v2.1.0) (2021-08-26)

### Features

* add autocomplete selected state ([#875](#875)) ([0e892ff](0e892ff))
* Add timetable patterns ([#877](#877)) ([cbee3f8](cbee3f8))
* added facilities icons ([#878](#878)) ([de557c0](de557c0))
* Adding shareable travel updates widget's documentation. ([#873](#873)) ([7110a99](7110a99))
@houbly houbly linked an issue Oct 18, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 18, 2021

🚀 Deployed on https://deploy-preview-887--wmnetwork.netlify.app

gldgrnt
gldgrnt previously approved these changes Oct 18, 2021
Copy link
Contributor

@gldgrnt gldgrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@gldgrnt gldgrnt requested a review from jkmnch October 18, 2021 08:50
Copy link
Contributor

@jkmnch jkmnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the default and expanded views, clicking on the Tram button takes me to the top of the page. Is this expected to happen since the pattern is built for the button to direct users to another page? If we can have it so that clicking on the Tram button doesn't take the user to the top of the page that would be ideal, but if it's required then that'll still be okay.

This is the same for the Nearest stops and stations pattern.

Otherwise, the patterns are looking great 👍

@houbly
Copy link
Contributor Author

houbly commented Oct 18, 2021

For the default and expanded views, clicking on the Tram button takes me to the top of the page. Is this expected to happen since the pattern is built for the button to direct users to another page? If we can have it so that clicking on the Tram button doesn't take the user to the top of the page that would be ideal, but if it's required then that'll still be okay.

This is the same for the Nearest stops and stations pattern.

Otherwise, the patterns are looking great 👍

It's just because they are dummy links using # since we don't want to direct users to the actual link if they click it. I have prevented them from scrolling now.

@houbly houbly requested a review from jkmnch October 18, 2021 11:19
Copy link
Contributor

@gldgrnt gldgrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@gldgrnt gldgrnt merged commit 39e2b43 into next-release Oct 18, 2021
@gldgrnt gldgrnt deleted the hb/feat/stop-station-patterns branch October 18, 2021 12:31
@github-actions github-actions bot mentioned this pull request Oct 19, 2021
wmcadigital-admin pushed a commit that referenced this pull request Oct 19, 2021
# [2.2.0](v2.1.0...v2.2.0) (2021-10-19)

### Features

*  add stops and stations patterns ([#887](#887)) ([39e2b43](39e2b43)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873)
* add facilities pattern ([#886](#886)) ([c2f5de2](c2f5de2)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873)
* add favourite action ([#888](#888)) ([01a9fdb](01a9fdb))
* add live departures patterns ([#885](#885)) ([0d87697](0d87697))
@wmcadigital-admin
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a stop or station patterns
5 participants