-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stops and stations patterns #887
Conversation
Next release
# [2.1.0](v2.0.1...v2.1.0) (2021-08-26) ### Features * add autocomplete selected state ([#875](#875)) ([0e892ff](0e892ff)) * Add timetable patterns ([#877](#877)) ([cbee3f8](cbee3f8)) * added facilities icons ([#878](#878)) ([de557c0](de557c0)) * Adding shareable travel updates widget's documentation. ([#873](#873)) ([7110a99](7110a99))
🚀 Deployed on https://deploy-preview-887--wmnetwork.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the default and expanded views, clicking on the Tram button takes me to the top of the page. Is this expected to happen since the pattern is built for the button to direct users to another page? If we can have it so that clicking on the Tram button doesn't take the user to the top of the page that would be ideal, but if it's required then that'll still be okay.
This is the same for the Nearest stops and stations pattern.
Otherwise, the patterns are looking great 👍
It's just because they are dummy links using # since we don't want to direct users to the actual link if they click it. I have prevented them from scrolling now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾
# [2.2.0](v2.1.0...v2.2.0) (2021-10-19) ### Features * add stops and stations patterns ([#887](#887)) ([39e2b43](39e2b43)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873) * add facilities pattern ([#886](#886)) ([c2f5de2](c2f5de2)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873) * add favourite action ([#888](#888)) ([01a9fdb](01a9fdb)) * add live departures patterns ([#885](#885)) ([0d87697](0d87697))
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add find a stop or station patterns
fixes #867