feat: add live departures patterns #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
src/wmnds/patterns/live-departures/live-departures-widget/_live-departures-widget.njk
Outdated
Show resolved
Hide resolved
src/wmnds/patterns/live-departures/live-departures-train/_live-departures-train.njk
Show resolved
Hide resolved
src/wmnds/patterns/live-departures/live-departures-widget/_live-departures-widget.njk
Outdated
Show resolved
Hide resolved
src/wmnds/patterns/live-departures/live-departures-widget/_live-departures-widget.njk
Outdated
Show resolved
Hide resolved
|
🚀 Deployed on https://deploy-preview-885--wmnetwork.netlify.app |
jkmnch
previously approved these changes
Oct 15, 2021
gldgrnt
suggested changes
Oct 18, 2021
src/wmnds/patterns/live-departures/live-departures-widget/_properties.njk.json
Outdated
Show resolved
Hide resolved
…perties.njk.json Co-authored-by: Gil <43111519+gldgrnt@users.noreply.github.com>
jkmnch
suggested changes
Oct 18, 2021
There was a problem hiding this comment.
Can the filtered live departures box for train show different train details to highlight that it has filtered the results? https://www.figma.com/file/rQRpNn6RM6nUcbm2HCWQlO/TfWM-Design-System?node-id=616%3A3128
The copy error is my mistake as I didn't change the text when I copied over the departures board from the prototype file into the DS file.
Thanks
jkmnch
approved these changes
Oct 18, 2021
Merged
wmcadigital-admin
pushed a commit
that referenced
this pull request
Oct 19, 2021
# [2.2.0](v2.1.0...v2.2.0) (2021-10-19) ### Features * add stops and stations patterns ([#887](#887)) ([39e2b43](39e2b43)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873) * add facilities pattern ([#886](#886)) ([c2f5de2](c2f5de2)), closes [#875](#875) [#877](#877) [#878](#878) [#873](#873) * add favourite action ([#888](#888)) ([01a9fdb](01a9fdb)) * add live departures patterns ([#885](#885)) ([0d87697](0d87697))
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added live departures patterns for Station/Stop pages
fixes #871