Catch all Java errors to avoid Android native app crashes #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was a previous attempt at a catch-all for exceptions, however the try/catch blocks were outside the threads being created so the only call being caught was the call to start the thread. If an exception happened inside the thread while it was running, it would be uncaught and cause an app crash.
To fix the error catching I did the following:
It might be worth removing the original try/catch blocks (outside the threads) to simplify the code since they aren't really catching much - what do you think?