This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Add cache invalidation for DataTypesModule #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overrides getDefinitionSummary, adding a hash based on the array of data types (array keys). Bug: T127095
filbertkm
changed the title
|
Ran the tests locally. Manually tested with Wikibase master (rebased against master and with ca3b4bd reverted). |
mariushoch
added a commit
that referenced
this pull request
Feb 16, 2016
Add cache invalidation for DataTypesModule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overrides getDefinitionSummary, adding a hash based on the array of data types (array keys).
still need to add tests, and apparently DataTypesModuleTest is broken on master and the tests are never run by travis, nor as part of the Wikidata build)
Bug: T127095