-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare the library for relasing as a npm package #126
Conversation
Moved contriburs, package description, keywords, and the bug tracker URL.
"wikibase-data-values" sound to generic. It's an entire concept that's named "DataValues", and part of the Wikibase software. Please use a more specific name. Also I wonder how this code is going to be used, now that the ResourceLoader definitions are gone. |
What alternative name you suggest then? |
"data-values/javascript" was the Composer name. I'm afraid I don't get why we need to shift away from what we had there? |
It is a javascript library, so I find this part not needed. |
I found it a good idea to stick to the existing name, and possibly make it "datavalues-javascript", or maybe "wikibase-datavalues-javascript". I looked the NPM documentation up and found the suggestion to not add "js" to package names. So we end with "wikibase-datavalues", either without or with the additional dash. |
Right, so "wikibase-data-values" (as currently is the name) or ""wikibase-datavalues" then? I personally don't like "datavalues", but I am not going to object it if that's what people want. |
Regarding the RL module part of you comment
I am going to have Wikibase define resource loader module it uses/needs. This should not belong to the library itself IMO. |
Thanks for the responses, that was very helpful for me. Let's stick to "…-data-values" with dashes then. That dash was there before. |
This is a part of https://phabricator.wikimedia.org/T177232.
Once this is merged, I am going to tag 1.0.0 release and publish it as a npm package called
wikibase-data-values
(alternative name suggestions should be preferably submitted before creating the npm package!).