Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the library for relasing as a npm package #126

Merged
merged 10 commits into from
Oct 4, 2017
Merged

Prepare the library for relasing as a npm package #126

merged 10 commits into from
Oct 4, 2017

Conversation

manicki
Copy link
Member

@manicki manicki commented Oct 2, 2017

This is a part of https://phabricator.wikimedia.org/T177232.
Once this is merged, I am going to tag 1.0.0 release and publish it as a npm package called wikibase-data-values (alternative name suggestions should be preferably submitted before creating the npm package!).

@thiemowmde
Copy link
Contributor

"wikibase-data-values" sound to generic. It's an entire concept that's named "DataValues", and part of the Wikibase software. Please use a more specific name.

Also I wonder how this code is going to be used, now that the ResourceLoader definitions are gone.

@manicki
Copy link
Member Author

manicki commented Oct 4, 2017

What alternative name you suggest then?

@thiemowmde
Copy link
Contributor

"data-values/javascript" was the Composer name. I'm afraid I don't get why we need to shift away from what we had there?

@manicki
Copy link
Member Author

manicki commented Oct 4, 2017

It is a javascript library, so I find this part not needed.
As far as I understand, npm convention for naming packages does not follow this "org/package" scheme.
That would mean it would just be "data-values". Fine with me, but really generic name IMO, therefore I added wikibase prefix.
What do you suggest instead?

@manicki manicki mentioned this pull request Oct 4, 2017
@thiemowmde
Copy link
Contributor

I found it a good idea to stick to the existing name, and possibly make it "datavalues-javascript", or maybe "wikibase-datavalues-javascript".

I looked the NPM documentation up and found the suggestion to not add "js" to package names. So we end with "wikibase-datavalues", either without or with the additional dash.

@manicki
Copy link
Member Author

manicki commented Oct 4, 2017

Right, so "wikibase-data-values" (as currently is the name) or ""wikibase-datavalues" then?

I personally don't like "datavalues", but I am not going to object it if that's what people want.

@manicki
Copy link
Member Author

manicki commented Oct 4, 2017

Regarding the RL module part of you comment

Also I wonder how this code is going to be used, now that the ResourceLoader definitions are gone.

I am going to have Wikibase define resource loader module it uses/needs. This should not belong to the library itself IMO.

@thiemowmde
Copy link
Contributor

Thanks for the responses, that was very helpful for me.

Let's stick to "…-data-values" with dashes then. That dash was there before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants