Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-0 compliance #3

Closed
JeroenDeDauw opened this issue Mar 1, 2014 · 3 comments
Closed

PSR-0 compliance #3

JeroenDeDauw opened this issue Mar 1, 2014 · 3 comments

Comments

@JeroenDeDauw
Copy link
Collaborator

Importing a bug of mine from https://bugzilla.wikimedia.org/show_bug.cgi?id=52455

Diff is not currently PSR-0 [0] compliant. More recently introduced classes typically are, though the initial core of the library is not. Some classes will need to be moved into sub namespaces to be compliant.

Once this is done, the manually maintained autoloading list at Diff.classes.php can be removed.

[0] https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md
@JeroenDeDauw
Copy link
Collaborator Author

The manually maintained classmap has been removed by #1

Still not PSR-0 complaint though.

@JeroenDeDauw
Copy link
Collaborator Author

Done for the tests by #7

@JeroenDeDauw JeroenDeDauw mentioned this issue Apr 9, 2014
Merged
@JeroenDeDauw
Copy link
Collaborator Author

Done in 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeroenDeDauw