Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ListDiffer #20

Closed
wants to merge 1 commit into from
Closed

Refactor ListDiffer #20

wants to merge 1 commit into from

Conversation

thiemowmde
Copy link
Contributor

This inlines a private method and arranges the code in a way that the deprecated logic comes first (the if...elseif part) and the non-deprecated logic last. Note that the constructor parameter is optional.

@JeroenDeDauw
Copy link
Collaborator

What made you make the order change?

@thiemowmde
Copy link
Contributor Author

How should I know what order you are referring to? MODE_NATIVE and MODE_STRICT? That's the order how they are defined, the first one is 0, the later 1.

@JeroenDeDauw JeroenDeDauw deleted the listDiffer branch January 23, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thiemowmde @JeroenDeDauw