Don't access vendor/bin in composer ci

[thiemowmde]

Remove "vendor/bin/" as suggested by @Krinkle in acd15a0#commitcomment-9861167.

I'm also moving the ci command to the top.

[JeroenDeDauw]

Restoring correct behavior by reverting

[Krinkle]

@JeroenDeDauw Have you tested it properly? Obviously composer does not, cannot and should not modify PATH in your own main bash process. Merely the subprocesses spawned by composer test and composer run-script ... Can you test again by running phpcs --version from the line in composer.json?

I've relied on that to work in countless repositories, platforms and environments. Both in composer and npm. I'd be really surprised if that doesn't work.

[JeroenDeDauw]

I noticed this because running composer ci gave me an error caused by it using the old version of PHPCS I have on my laptop

[Krinkle]

@JeroenDeDauw It works for me locally, and I'm using it via Travis CI and Jenkins in many projects. When I run self-update to latest master its broken indeed. I ran composer self-update --rollback since it's clearly a regression. Filed upstream at composer/composer#3820. Thanks!

(Note: One should run composer run-script <task> not composer <task>)

[JeroenDeDauw]

@Krinkle Thanks for looking into this further

To be honest I'm a bit dubious about making this change even if it does work. In practical terms it seems to not matter the slightest, except for one case I can think off: someone that is not familiar with composer commands reading the code. For them the more explicit version ought to be clearer.