Allow switching language using lang url param #219

addshore · 2016-04-27T08:39:37Z

Currently if a language is selected and i18n messages
are missing the i18n code will be displayed instead

Currently if a language is selected and i18n messages are missing the i18n code will be displayed instead If no language is passed a default of de is used.

jakobw · 2016-04-27T11:51:54Z

This approach seems a bit hacky to me. Can't we take the remaining strings from the index.html, put them in the i18n.json and then do the language switching entirely in JS?

manicki · 2016-04-27T11:54:10Z

I was actually also thinking about something like what @jakobw suggested. I am not sure which solution will be nicer though.

addshore · 2016-04-27T15:49:23Z

Well assuming not all browsers have JS we would probably always went a landing page which also renders useful content without JS.
So if we want the landing page to also be localizable this would have to be done in PHP.

Fixing the landing page for non JS browsers is also something that should be done in my opinion saying that the site requires JS, right now it just half loads and doesn't work.

manicki · 2016-04-27T15:54:43Z

That's a good point. There should be some kind of i18n-enabled noscript info.

This branch is pushing towards the i18n not only being handeled by JS thus it makes sense to split the files out of the js dir. For easy adding of more languages the i18n json file has also been split into 1 per language.

addshore · 2016-04-27T16:50:20Z

I went ahead and moved the i18n files out of the JS directory (as they are used by the bit of php now)

I also went ahead and created a basic noscript landing page.

Current master looks like this:

Now it looks like this:

(although the message needs translating to German and adding to the i18n file)

addshore · 2016-04-27T19:27:11Z

My current thoughts for the large blocks of text on the landing page are that they could be split out into separate html files which could then each be localized?

./i18n/html/de/about.html
./i18n/html/de/legalt.html

The text on feedback is probably small enough to keep in the json file but the about and legal sections just seems a bit insane.

After this the only js strings not in the i18n files are the internal errors that afaik will only go to the JS console and will not be presented to users.

This makes the feedback form pass through the language to the email backend so that localized errors and thanks messages can be send back to the frontend.

addshore · 2016-04-27T20:20:12Z

As far as I can tell this PR now covers i18n for all strings (except internal exception messages which are not really user facing).

jakobw · 2016-04-28T08:36:31Z

Ohh, that looks really cool now!

jakobw · 2016-04-28T08:43:57Z

If I remember correctly I also suggested putting large blocks of texts in files so they can be translated but somehow after we discussed this we concluded that it would be better to have them all in one file (split large texts into paragraphs) to make it easier to just give it to people for translation. I think this looks pretty good though and it's super nice that we can even have a translated message for people who don't have JS activated. What do @manicki and @tobijat think? :)

jakobw · 2016-04-28T08:46:09Z

backend/src/Actions/FeedbackAction.php

+		if( !file_exists( $langFile ) ) {
+			$langFile = __DIR__ . '/../../../i18n/de/i18n.json';
+		}
+		$this->i18n = json_decode( file_get_contents( $langFile ), true );

 		if ( $this->requestValid( $app['request'] ) ) {


Could also be $this->requestValid( $request )

jakobw · 2016-04-28T08:49:17Z

index.php

+}
+
+// Also replace html snippets
+$htmlFiles = array(


We can haz new array [] syntax!

Will do everywhere! :)

addshore · 2016-04-28T08:52:20Z

Yes the longer texts in files do seem quite manageable, however I feel that I should take a look at legal.html and remove the tracking switch from there....

I guess the switch itself should remain in the main html file and the strings around there should head to the i18n.json file

jakobw · 2016-04-28T08:58:40Z

js/app/Messages.js


-module.exports = new Polyglot( { phrases: i18n[ 'de' ] } );
+var getParam = function getUrlParameter( sParam ) {


I thought JS would have a built-in thing to deal with URLs but google didn't spit anything out :/

This means the order of the replacements does not matter. Before if the two keys below got replaced in this order bad things would happen. index.foo-bar index.foo-bar-1

manicki · 2016-04-28T10:24:37Z

i18n/de/i18n.json

+  "index": {
+    "title": "Lizenzhinweisgenerator",
+    "description": "Lizenzhinweise für Bilder aus Wikipedia und Wikimedia Commons",
+    "no-script": "Sie müssen JavaScript zur Nutzung dieser Website aktiviert.",


I am guessing this is not entirely correct Kraut speak, although it contains all words I'd expect: "müssen", "Javascript", "aktiviert" :)
Let's have @jakobw and @WMDE-Fisch suggest something better

Haha, close enough though. Something like "Zur Nutzung dieser Webseite muss JavaScript aktiviert sein." would be better.

manicki · 2016-04-28T10:38:19Z

Looks really nice!
I really like having translatable noscript information and splitting i18n json files into separate file per language.
There is a little bit of inconsistency ie. when some i18n.index translations are missing there is no German fallback. For instance if I create an empty i18n/en/i18n.json file all HTML stuff will be in German same as all JS generated text but i18n.index things will remain untranslated, ie. it will be "{{i18n.index.title}}" instead of "Lizenz..." displayed on the front screen.
But I don't think it is a problem as it will only occur where there are some particular translations missing which can actually be helpful in the process of adding new language etc as it is obvious what is still not translated.

So basically it will be ready to go after updating one translation to what Jakob suggested.

WMDE-Fisch · 2016-04-28T11:52:25Z

+:100:

addshore force-pushed the langParam branch from bb61b81 to 6590a26 Compare April 27, 2016 08:47

addshore added 2 commits April 27, 2016 10:31

Allow switching language using lang url param

f6d2511

Currently if a language is selected and i18n messages are missing the i18n code will be displayed instead If no language is passed a default of de is used.

Allow translating strings on landing page

286d2b9

addshore force-pushed the langParam branch from 6590a26 to 286d2b9 Compare April 27, 2016 09:32

Move i18n out of the JS directory & split

8ed3991

This branch is pushing towards the i18n not only being handeled by JS thus it makes sense to split the files out of the js dir. For easy adding of more languages the i18n json file has also been split into 1 per language.

Add noscript landing page

96ba12a

addshore force-pushed the langParam branch from 0d03b11 to 96ba12a Compare April 27, 2016 16:56

addshore added 2 commits April 27, 2016 20:07

Show WMDE logo in non JS landing page

bb98e02

Add short index messages to i18n file

5e59ac9

addshore added 4 commits April 27, 2016 20:41

Finish translating index page

93209c6

Simplify i18n directory structure

0bb7229

Translate final string in js files

ed1593d

After this the only js strings not in the i18n files are the internal errors that afaik will only go to the JS console and will not be presented to users.

Add i18n to the email backend

8022da9

This makes the feedback form pass through the language to the email backend so that localized errors and thanks messages can be send back to the frontend.

Translate no JavaScript message

dbde66f

jakobw reviewed Apr 28, 2016
View reviewed changes

Use $request var in FeedbackAction

70b39f8

jakobw reviewed Apr 28, 2016
View reviewed changes

Use short array syntax in index.php

8a1e6a0

jakobw reviewed Apr 28, 2016
View reviewed changes

Switch to {{i18n.*}} i18n tags in index.html

c0767ac

This means the order of the replacements does not matter. Before if the two keys below got replaced in this order bad things would happen. index.foo-bar index.foo-bar-1

Split legal tracking switch out of i18n file

908b218

manicki reviewed Apr 28, 2016
View reviewed changes

Updsate JS msg translation & remove rouge quote

5e3addc

jakobw merged commit 61d3549 into master Apr 28, 2016

jakobw deleted the langParam branch April 28, 2016 12:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow switching language using lang url param #219

Allow switching language using lang url param #219

addshore commented Apr 27, 2016

jakobw commented Apr 27, 2016

manicki commented Apr 27, 2016

addshore commented Apr 27, 2016

manicki commented Apr 27, 2016

addshore commented Apr 27, 2016 •

edited

addshore commented Apr 27, 2016

addshore commented Apr 27, 2016

jakobw commented Apr 28, 2016

jakobw commented Apr 28, 2016

jakobw Apr 28, 2016

addshore Apr 28, 2016

jakobw Apr 28, 2016

addshore Apr 28, 2016

addshore commented Apr 28, 2016

jakobw Apr 28, 2016

manicki Apr 28, 2016

jakobw Apr 28, 2016

manicki commented Apr 28, 2016

WMDE-Fisch commented Apr 28, 2016


		module.exports = new Polyglot( { phrases: i18n[ 'de' ] } );
		var getParam = function getUrlParameter( sParam ) {

Allow switching language using lang url param #219

Allow switching language using lang url param #219

Conversation

addshore commented Apr 27, 2016

jakobw commented Apr 27, 2016

manicki commented Apr 27, 2016

addshore commented Apr 27, 2016

manicki commented Apr 27, 2016

addshore commented Apr 27, 2016 • edited

addshore commented Apr 27, 2016

addshore commented Apr 27, 2016

jakobw commented Apr 28, 2016

jakobw commented Apr 28, 2016

jakobw Apr 28, 2016

Choose a reason for hiding this comment

addshore Apr 28, 2016

Choose a reason for hiding this comment

jakobw Apr 28, 2016

Choose a reason for hiding this comment

addshore Apr 28, 2016

Choose a reason for hiding this comment

addshore commented Apr 28, 2016

jakobw Apr 28, 2016

Choose a reason for hiding this comment

manicki Apr 28, 2016

Choose a reason for hiding this comment

jakobw Apr 28, 2016

Choose a reason for hiding this comment

manicki commented Apr 28, 2016

WMDE-Fisch commented Apr 28, 2016

addshore commented Apr 27, 2016 •

edited