Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak comment in DecimalValue::newFromArray #108

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DataValues/DecimalValue.php
Original file line number Diff line number Diff line change
Expand Up @@ -355,10 +355,10 @@ public function getArrayValue() {
*
* @deprecated since 0.8.3. Static DataValue::newFromArray constructors like this are
* underspecified (not in the DataValue interface), and misleadingly named (should be named
* newFromArrayValue). Instead, use DataValue builder callbacks in @see DataValueDeserializer.
* newFromArrayValue). Instead, just use the constructor.
*
* @param mixed $data Warning! Even if this is expected to be a value as returned by
* @see getArrayValue, callers of this specific newFromArray implementation can not guarantee
* @see getArrayValue, callers of this specific newFromArray implementation cannot guarantee
* this. This is not guaranteed to be a string!
*
* @throws InvalidArgumentException if $data is not in the expected format. Subclasses of
Expand Down