Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wikibase PHPCS rule set to latest release #23

Merged
merged 1 commit into from
Nov 6, 2018
Merged

Update Wikibase PHPCS rule set to latest release #23

merged 1 commit into from
Nov 6, 2018

Conversation

thiemowmde
Copy link
Contributor

No description provided.

lucaswerkmeister
lucaswerkmeister approved these changes Nov 6, 2018
View reviewed changes
Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no code changes necessary. Nice!

@lucaswerkmeister
Copy link
Member

I hope the CI failures on HHVM are unrelated…

@lucaswerkmeister lucaswerkmeister merged commit 8a78bb7 into master Nov 6, 2018
@lucaswerkmeister lucaswerkmeister deleted the phpCsUpdate branch November 6, 2018 10:47
lucaswerkmeister added a commit that referenced this pull request Nov 6, 2018
@lucaswerkmeister
Fix class name
ad1fa92 
This was the only occurrence of “DeSerializer” with an uppercase S, and
it showed up in a CI failure in #23; class names are supposed to be case
insensitive, but let’s fix it anyways (makes it easier to find uses of
the class with e. g. `git grep`) and see if that also resolves the CI
problem.
@lucaswerkmeister lucaswerkmeister mentioned this pull request Nov 6, 2018
Merged
thiemowmde pushed a commit that referenced this pull request Nov 6, 2018
@lucaswerkmeister @thiemowmde
Fix class name (#24)
4e6b276 
This was the only occurrence of “DeSerializer” with an uppercase S, and
it showed up in a CI failure in #23; class names are supposed to be case
insensitive, but let’s fix it anyways (makes it easier to find uses of
the class with e. g. `git grep`) and see if that also resolves the CI
problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswerkmeister lucaswerkmeister lucaswerkmeister approved these changes

@addshore addshore Awaiting requested review from addshore

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiemowmde @lucaswerkmeister