Remove misleading calendar model output #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brightbyte
pushed a commit
that referenced
this pull request
Apr 16, 2015
Considering that giving no calendar model is treated as equivalent to saying "gregorian" by the time parser, it should be safe to remove "gregorian" from the output. I was going to suggest to hold this patch back until we have a decision on the interpretation of the calendar model, but it seems pointless: if the interpretation is that the timestamp is always gregorian, then omitting the calendar in the output makes no difference; if the interpretation is that the timestamp depends on the calendar model identifier, then outputting "gregorian" indiscriminately would be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply removes the discussed, confusing calendar model display from this formatter. It's split from #49 (and will cause merge conflicts, but I would like to discuss the two changes in two independent pull requests).
Note that this formatter is currently unused. The Wikibase UI uses the
HtmlTimeFormatterinstead (which, by the way, uses the calendar model as "actual" and not "preferred calendar").This patch also removes dead code that is not used anywhere, most notably the redundant language option.