Call getQualifiers and getReferences outside of iterator_to_array

In the getAllSnaks calls in Claim and Statement, it seems in some situations that the Traversable objects are being converted to array, by reference, in the ReferenceList itself and possibly for qualifiers also. This change may help fix bug 71519.
wmde · Oct 7, 2014 · 63d006f · 63d006f
1 parent 5875353
commit 63d006f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Claim/Claim.php b/src/Claim/Claim.php
@@ -190,7 +190,8 @@ public function getAllSnaks() {
 		$snaks = array();
 
 		$snaks[] = $this->getMainSnak();
-		$snaks = array_merge( $snaks, iterator_to_array( $this->getQualifiers() ) );
+		$qualifiers = $this->getQualifiers();
+		$snaks = array_merge( $snaks, iterator_to_array( $qualifiers ) );
 
 		return $snaks;
 	}

diff --git a/src/Statement/Statement.php b/src/Statement/Statement.php
@@ -141,7 +141,8 @@ public function getAllSnaks() {
 
 		/* @var Reference $reference */
 		foreach( $this->getReferences() as $reference ) {
-			$snaks = array_merge( $snaks, iterator_to_array( $reference->getSnaks() ) );
+			$referenceSnaks = $reference->getSnaks();
+			$snaks = array_merge( $snaks, iterator_to_array( $referenceSnaks ) );
 		}
 
 		return $snaks;