Merge pull request #215 from wmde/ImproveHashArrayTypeErrorMessage

Show better error for "wrong" objects in HashArray
wmde · Oct 1, 2014 · 5875353 · 5875353
2 parents d8f673d + 2f05015
commit 5875353
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/HashArray.php b/src/HashArray.php
@@ -413,8 +413,11 @@ protected function hasValidType( $value ) {
 	 */
 	protected function setElement( $index, $value ) {
 		if ( !$this->hasValidType( $value ) ) {
+			$type = is_object( $value ) ? get_class( $value ) : gettype( $value );
+
 			throw new InvalidArgumentException(
-				'Can only add ' . $this->getObjectType() . ' implementing objects to ' . get_called_class() . '.'
+				'Can only add ' . $this->getObjectType() . ' implementing objects to ' . get_called_class() . ', ' .
+				'but found a ' . $type . ' instead'
 			);
 		}